Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for 'disabled' files in plugins #1323

Closed
Klap-in opened this issue Aug 22, 2015 · 2 comments
Closed

Remove support for 'disabled' files in plugins #1323

Klap-in opened this issue Aug 22, 2015 · 2 comments

Comments

@Klap-in
Copy link
Collaborator

Klap-in commented Aug 22, 2015

The current mechanism is that the disabled plugins are stored in conf/plugins.local.php
At the moment the lib/plugins/[plugin]/disabled files are deprecated since 2011, but still available.

https://github.com/splitbrain/dokuwiki/blob/master/inc/plugincontroller.class.php#L166

@selfthinker selfthinker changed the title Remove support plugin disabled files Remove support for 'disabled' files in plugins Aug 23, 2015
@splitbrain splitbrain added this to the Elenor of Tsort - coming release milestone Apr 18, 2016
Klap-in added a commit that referenced this issue Apr 18, 2016
@Klap-in
Copy link
Collaborator Author

Klap-in commented Apr 18, 2016

The condition || ($plugin === 'plugin' && isset($conf['pluginmanager']) && !$conf['pluginmanager']) remains from the previous plugin manager.
I will remove it as well.
more background: c45608d

Question:

               if (substr($plugin,-9) == '.disabled') {
                    // the plugin was disabled by rc2009-01-26
                    // disabling mechanism was changed back very soon again
                    // to keep everything simple we just skip the plugin completely
                    continue;
                } else

Is it ok for you, to remove this <pluginfoldername>.disable feature too?

@splitbrain
Copy link
Collaborator

Yes, that should go too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants